CS-10802: Refactor SearchPanel – extract utilities and simplify args by FadhlanR · Pull Request #4418 · cardstack/boxel

FadhlanR · 2026-04-16T08:32:28Z

Summary

Simplify SearchPanel args to use domain types (URL[], ResolvedCodeRef[]) instead of internal concerns (PickerOption[], booleans)
Extract TypeSummariesResource from SearchPanel; introduce RealmFilter/TypeFilter interfaces
Move all card-search utilities to app/utils/card-search/ (7 focused files: url, query-builder, type-filter, recent-cards, sections, section-pagination, types)
Deduplicate URL parsing logic shared between search-sheet and search-content into isURLSearchKey()/resolveSearchKeyAsURL()
Slim SearchContent from 736 to ~500 lines by extracting section building, pagination, and filtering into pure helpers

Test plan

Existing integration tests pass (card-catalog, operator-mode-ui)
Card catalog modal: realm/type pickers, search, pagination, create-new all work
Search sheet: search, realm filtering, type filtering, recent cards, URL lookup all work
"Show Only" focus/unfocus on sections works
"Show More" pagination within sections works

Linear: https://linear.app/cardstack/issue/CS-10802

🤖 Generated with Claude Code

…cerns Replace cluttered args (consumingRealm, preselectConsumingRealm, availableRealmUrls, onFilterChange) with cleaner domain-typed alternatives (initialSelectedRealms, initialSelectedTypes, onRealmChange, onTypeChange) so callers deal with URL[] and ResolvedCodeRef[] instead of PickerOption[] and booleans. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Replace SearchPanel's internal-leaking args with domain types (URL[], ResolvedCodeRef[] instead of PickerOption[], booleans) - Extract TypeSummariesResource from SearchPanel - Introduce RealmFilter/TypeFilter interfaces to bundle picker args - Move utilities to app/utils/card-search/ (7 focused files) - Deduplicate URL parsing into shared isURLSearchKey/resolveSearchKeyAsURL - Extract section building, pagination, type filtering, recent cards filtering into pure helper functions - Slim SearchContent from 736 to ~500 lines Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-16T08:40:15Z

Preview deployments

github-actions · 2026-04-16T08:55:22Z

Realm Server Test Results

1 files ±0 1 suites ±0 14m 42s ⏱️ +28s
894 tests ±0 894 ✅ ±0 0 💤 ±0 0 ❌ ±0
966 runs ±0 966 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 45c304c. ± Comparison against base commit e3f0866.

♻️ This comment has been updated with latest results.

github-actions · 2026-04-16T08:57:34Z

Host Test Results

2 265 tests +19 2 250 ✅ +19 2h 31m 47s ⏱️ - 1m 45s
1 suites ± 0 15 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit 45c304c. ± Comparison against base commit e3f0866.

This pull request removes 1 and adds 20 tests. Note that renamed tests count towards both.

Chrome ‑ Integration | commands | search-and-choose: uses sourceContextCodeRef source instead of the searched type source

Chrome ‑ Integration | Command | host command schema generation test > command schema generation: getInputJsonSchema for EvaluateModuleCommand
Chrome ‑ Integration | Command | host command schema generation test > command schema generation: getInputJsonSchema for InstantiateCardCommand
Chrome ‑ Integration | commands | evaluate-module: module with broken import fails evaluation
Chrome ‑ Integration | commands | evaluate-module: valid module passes evaluation
Chrome ‑ Integration | commands | instantiate-card: containsMany field with non-array value fails instantiation
Chrome ‑ Integration | commands | instantiate-card: valid card with instance data passes instantiation
Chrome ‑ Integration | commands | instantiate-card: valid card with no instance data passes instantiation
Chrome ‑ Integration | commands | search-and-choose: LLM index selection uses sourceContextCodeRef as context
Chrome ‑ Integration | commands | search-and-choose: parseIndicesFromLlmOutput accepts numeric literals
Chrome ‑ Integration | commands | search-and-choose: parseIndicesFromLlmOutput accepts quoted numeric strings
…

♻️ This comment has been updated with latest results.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf6d5d0ea6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Refactors the card search UI by simplifying SearchPanel’s public API to domain types, extracting type-summary fetching into a dedicated resource, and moving search logic into focused utilities.

Changes:

Replaced SearchPanel picker/boolean args with domain-level URL[] / ResolvedCodeRef[] and RealmFilter / TypeFilter interfaces.
Extracted type summary fetching/pagination into TypeSummariesResource, and moved search helpers (URL parsing, type filtering, section building, recents logic) into app/utils/card-search/*.
Updated host/operator-mode UI + Boxel Picker to display checkbox selection state and adjusted integration tests accordingly.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/host/tests/integration/components/operator-mode-ui-test.gts	Updates integration assertions to use picker checkbox-selected UI + new `TypeSummariesResource.PAGE_SIZE`.
packages/host/app/utils/card-search/url.ts	Adds shared URL/empty-search helpers for search key parsing.
packages/host/app/utils/card-search/types.ts	Introduces domain types (`NewCardArgs`) and shared `removeFileExtension`.
packages/host/app/utils/card-search/type-filter.ts	Extracts filter/type-ref logic (root type handling, subtype checks, type-ref filtering).
packages/host/app/utils/card-search/sections.ts	Extracts section data types + builders (recents/url/query sections) and assembly ordering.
packages/host/app/utils/card-search/section-pagination.ts	Extracts section focus + “show more” pagination into a tracked helper class.
packages/host/app/utils/card-search/recent-cards.ts	Extracts recent-card filtering + sorting logic (including type constraints).
packages/host/app/utils/card-search/query-builder.ts	Removes duplicated helpers and reuses new URL/empty helpers; keeps query construction centralized.
packages/host/app/services/realm-server.ts	Adds `canFetch` guard used by type summaries resource to avoid early fetch attempts.
packages/host/app/services/operator-mode-state-service.ts	Repoints `removeFileExtension` import to new utils location.
packages/host/app/resources/type-summaries.ts	New resource for fetching/paginating type summaries and maintaining selected types.
packages/host/app/components/type-picker/index.gts	Switches to `TypeFilter` interface and maps domain options/selection to Picker options.
packages/host/app/components/search-sheet/index.gts	Uses shared URL helpers and new SearchPanel args/events (`onRealmChange`/`onTypeChange`).
packages/host/app/components/realm-picker/index.gts	Switches to `RealmFilter` interface and maps selected URLs to Picker options.
packages/host/app/components/operator-mode/operator-mode-overlays.gts	Repoints `removeFileExtension` import to new utils location.
packages/host/app/components/card-search/section-header.gts	Imports `RealmSectionInfo` from extracted sections util types.
packages/host/app/components/card-search/search-result-section.gts	Imports section + `NewCardArgs` types from extracted utils.
packages/host/app/components/card-search/search-result-header.gts	Imports `NewCardArgs` from extracted utils.
packages/host/app/components/card-search/search-content.gts	Large refactor: uses extracted helpers/resources; replaces internal pagination/section building.
packages/host/app/components/card-search/search-bar.gts	Simplifies args to accept `realmFilter` / `typeFilter`.
packages/host/app/components/card-search/panel.gts	Major simplification: delegates type summaries to resource and yields domain filter objects.
packages/host/app/components/card-search/item-button.gts	Repoints `removeFileExtension`/`NewCardArgs` imports to new utils.
packages/host/app/components/card-search/constants.ts	Adds clarification about dual-mode sorting + recent-card sorting helper.
packages/host/app/components/card-catalog/modal.gts	Updates SearchPanel usage for new args, and derives initial selected realms.
packages/boxel-ui/test-app/tests/integration/components/picker-test.gts	Adds coverage for checkbox selected-state rendering in picker dropdown.
packages/boxel-ui/addon/src/components/picker/index.gts	Changes selected-state logic to use `id` equality instead of object identity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lukemelia

Nice cleanup

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

FadhlanR and others added 3 commits April 16, 2026 15:31

Introduce type summaries resource

5061e3b

FadhlanR added 2 commits April 16, 2026 17:08

lint fix

b155b20

test-app lint fix

bf6d5d0

FadhlanR marked this pull request as ready for review April 16, 2026 10:40

FadhlanR requested a review from a team April 16, 2026 10:41

chatgpt-codex-connector bot reviewed Apr 16, 2026

View reviewed changes

Comment thread packages/host/app/resources/type-summaries.ts

Comment thread packages/host/app/resources/type-summaries.ts

habdelra requested a review from Copilot April 16, 2026 14:13

Copilot started reviewing on behalf of habdelra April 16, 2026 14:14 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread packages/host/app/components/realm-picker/index.gts

Comment thread packages/host/app/components/type-picker/index.gts

Comment thread packages/host/app/resources/type-summaries.ts

lukemelia approved these changes Apr 16, 2026

View reviewed changes

Clear stale type filter state on failed summaries fetch

45c304c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CS-10802: Refactor SearchPanel – extract utilities and simplify args#4418

CS-10802: Refactor SearchPanel – extract utilities and simplify args#4418
FadhlanR wants to merge 6 commits intomainfrom
refactor-search-panel-args

FadhlanR commented Apr 16, 2026

Uh oh!

github-actions bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukemelia left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

FadhlanR commented Apr 16, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview deployments

Uh oh!

github-actions bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Realm Server Test Results

Uh oh!

github-actions bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Host Test Results

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukemelia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 16, 2026 •

edited

Loading

github-actions bot commented Apr 16, 2026 •

edited

Loading

github-actions bot commented Apr 16, 2026 •

edited

Loading